My little c++ program

[lolimsoasd]

I have this kind of code:

#include <iostream>

int main () {
	char answer;
	std::cout << "Am I best? <y/n>" << std::endl;
	do {
	std::cin >> answer;
	if (answer=='y' || answer=='Y')
		std::cout << "Good!" << std::endl;
	else if (answer=='n' || answer=='N')
		std::cout << "You are an idiot." << std::endl;
	else
		std::cout << "Answer the question right, idiot." <<std::endl;
	} while (answer!='y' || answer!= 'n' ||answer!='Y' || answer!= 'N');
	system("pause");
	return 0;
}

It works, but if I input "ynynyn", without quotes, the cmd will return:

Good!
You are an idiot.
Good!
You are an idiot.
Good!
You are an idiot.

how could I avoid this?

[udevil_666]

Re: My little c++ program

this made me laugh hard lol, don't know how to help thou?!?!;)

Good!
You are an idiot.
Good!
You are an idiot.
Good!
You are an idiot. hahahah

[lolimsoasd]

Re: My little c++ program

this made me laugh hard lol, don't know how to help thou?!?!;)

Good!
You are an idiot.
Good!
You are an idiot.
Good!
You are an idiot. hahahah

yeah it's pretty insane :D and when i input something like "kkkkkkkk" it will just return:

Answer the question right, idiot.
Answer the question right, idiot.
Answer the question right, idiot.
Answer the question right, idiot.
Answer the question right, idiot.
Answer the question right, idiot.
Answer the question right, idiot.
Answer the question right, idiot.

[Rudolf123]

Re: My little c++ program

Cheap and not perfect solution, but this kind of fixes it

#include <iostream>

int main () {
	char answer;
	std::cout << "Am I best? <y/n>" << std::endl;
	do {
	std::cin >> answer;
	if (answer=='y' || answer=='Y'){
		std::cout << "Good!" << std::endl;
		break;
	}
	else if (answer=='n' || answer=='N'){
		std::cout << "You are an idiot." << std::endl;
		break;
	}else{
		std::cout << "Answer the question right, idiot." <<std::endl;
		break;
	}
	} while (answer!='y' || answer!= 'n' ||answer!='Y' || answer!= 'N');
	system("pause");
	return 0;
}

[lolimsoasd]

Re: My little c++ program

Cheap and not perfect solution, but this kind of fixes it

#include <iostream>

int main () {
	char answer;
	std::cout << "Am I best? <y/n>" << std::endl;
	do {
	std::cin >> answer;
	if (answer=='y' || answer=='Y'){
		std::cout << "Good!" << std::endl;
		break;
	}
	else if (answer=='n' || answer=='N'){
		std::cout << "You are an idiot." << std::endl;
		break;
	}else{
		std::cout << "Answer the question right, idiot." <<std::endl;
		break;
	}
	} while (answer!='y' || answer!= 'n' ||answer!='Y' || answer!= 'N');
	system("pause");
	return 0;
}

thanks,

also

} while (answer!='y' || answer!= 'n' ||answer!='Y' || answer!= 'N');

should be replaced with

} while (answer!='y' && answer!= 'n' && answer!='Y' && answer!= 'N');

ok hmm i'm learning!